lkml.org 
[lkml]   [2010]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/12] Revert "perf record: Intercept all events"
    Date
    This reverts commit f5a2c3dce03621b55f84496f58adc2d1a87ca16f.

    This patch is required for making "perf lock rec" work.
    The commit f5a2c3dce0 changes write_event() of builtin-record.c .
    And changed write_event() sometimes doesn't stop with perf lock rec.

    I'm researching what makes write_event() loop infinity,
    and noticed that there are some events with event_t->header.size == 0.
    But the detail of the problem,
    like kind of these events, isn't clear...

    If you know something related to this problem,
    could you tell me, Arnaldo?

    Signed-off-by: Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
    Cc: Frédéric Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    ---
    tools/perf/builtin-record.c | 28 ++++++++++------------------
    1 files changed, 10 insertions(+), 18 deletions(-)

    diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
    index 7bb9ca1..614fa9a 100644
    --- a/tools/perf/builtin-record.c
    +++ b/tools/perf/builtin-record.c
    @@ -113,24 +113,16 @@ static void write_output(void *buf, size_t size)

    static void write_event(event_t *buf, size_t size)
    {
    - size_t processed_size = buf->header.size;
    - event_t *ev = buf;
    -
    - do {
    - /*
    - * Add it to the list of DSOs, so that when we finish this
    - * record session we can pick the available build-ids.
    - */
    - if (ev->header.type == PERF_RECORD_MMAP) {
    - struct list_head *head = &dsos__user;
    - if (ev->header.misc == 1)
    - head = &dsos__kernel;
    - __dsos__findnew(head, ev->mmap.filename);
    - }
    -
    - ev = ((void *)ev) + ev->header.size;
    - processed_size += ev->header.size;
    - } while (processed_size < size);
    + /*
    + * Add it to the list of DSOs, so that when we finish this
    + * record session we can pick the available build-ids.
    + */
    + if (buf->header.type == PERF_RECORD_MMAP) {
    + struct list_head *head = &dsos__user;
    + if (buf->mmap.header.misc == 1)
    + head = &dsos__kernel;
    + __dsos__findnew(head, buf->mmap.filename);
    + }

    write_output(buf, size);
    }
    --
    1.6.5.2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-01-22 14:43    [W:0.080 / U:61.992 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site