lkml.org 
[lkml]   [2010]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] perf tools: fix dc8d6ab typo prohibiting perf top symbol annotation
Em Fri, Jan 22, 2010 at 07:39:39AM +0100, Mike Galbraith escreveu:
>
> perf tools: fix dc8d6ab typo prohibiting perf top symbol annotation
>
> Signed-off-by: Mike Galbraith <efault@gmx.de>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> LKML-Reference: <new-submission>
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 6f30fe1..af2e224 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -1669,7 +1669,7 @@ do_kallsyms:
> free(kallsyms_allocated_filename);
>
> out_try_fixup:
> - if (err > 0) {
> + if (err <= 0) {
> out_fixup:
> if (kallsyms_filename == NULL)
> dso__set_long_name(self, strdup("[kernel.kallsyms]"));

Strange, we need to fixup the map only if we found some symbol, so all
the routines there return the number of symbols found or -1 for errors,
investigating perf top symbol annotation now...

- Arnaldo


\
 
 \ /
  Last update: 2010-01-22 12:25    [from the cache]
©2003-2011 Jasper Spaans