lkml.org 
[lkml]   [2010]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] resources: introduce generic page_is_ram()
    On Thu, Jan 21, 2010 at 10:15:50PM -0700, Xiaotian Feng wrote:
    > On Fri, Jan 22, 2010 at 11:21 AM, Wu Fengguang <fengguang.wu@intel.com> wrote:
    > > It's based on walk_system_ram_range(), for archs that don't have
    > > their own page_is_ram().
    > >
    > > The static verions in MIPS and SCORE are also made global.
    > >
    > > CC: Chen Liqin <liqin.chen@sunplusct.com>
    > > CC: Lennox Wu <lennox.wu@gmail.com>
    > > CC: Ralf Baechle <ralf@linux-mips.org>
    > > CC: Américo Wang <xiyou.wangcong@gmail.com>
    > > CC: linux-mips@linux-mips.org
    > > CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > > CC: Yinghai Lu <yinghai@kernel.org>
    > > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
    > > ---
    > >  arch/mips/mm/init.c    |    2 +-
    > >  arch/score/mm/init.c   |    2 +-
    > >  include/linux/ioport.h |    2 ++
    > >  kernel/resource.c      |   11 +++++++++++
    > >  4 files changed, 15 insertions(+), 2 deletions(-)
    > >
    > > --- linux-mm.orig/kernel/resource.c     2010-01-22 11:20:34.000000000 +0800
    > > +++ linux-mm/kernel/resource.c  2010-01-22 11:20:35.000000000 +0800
    > > @@ -327,6 +327,17 @@ int walk_system_ram_range(unsigned long
    > >
    > >  #endif
    > >
    > > +#define PAGE_IS_RAM    24
    > > +static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
    > > +{
    > > +       return PAGE_IS_RAM;
    > > +}
    > > +int __attribute__((weak)) page_is_ram(unsigned long pfn)
    > > +{
    > > +       return PAGE_IS_RAM == walk_system_ram_range(pfn, 1, NULL, __is_ram);
    > > +}
    > > +#undef PAGE_IS_RAM
    > > +
    >
    > I'm not sure, but any build test for powerpc/mips/score?

    Sorry, no build tests yet:

    /bin/sh: score-linux-gcc: command not found

    I just make the mips/score page_is_ram() non-static and assume that
    will make it compile.

    > walk_system_ram_range is defined when CONFIG_ARCH_HAS_WALK_MEMORY is not set.
    > Is it safe when CONFIG_ARCH_HAS_WALK_MEMORY is set for some powerpc archs?

    Good question. Grep shows that CONFIG_ARCH_HAS_WALK_MEMORY is only
    defined for powerpc, and it has its own page_is_ram() as well as
    walk_system_ram_range().

    walk_system_ram_range() must be defined somewhere because it is
    expected to be generic routine: exported and called from both
    in-kernel and out-of-tree code.

    Thanks,
    Fengguang
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-01-22 06:39    [W:0.038 / U:30.788 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site