lkml.org 
[lkml]   [2010]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [x86] Unify semaphore_32.S and rwlock_64.S
On 01/20/2010 04:02 PM, H. Peter Anvin wrote:
> On 01/20/2010 03:57 PM, Linus Torvalds wrote:
>>
>
> I'm somewhat unhappy about that notion, mostly because it means Yet
> Another Thing To Verify[TM]. I would like to look at the relative code
> sizes of 2^31 and 2^30, however, if all it means is that *one*
> instruction in *one* asm has to be different, I'd rather leave it at 2^31.
>

Well, there is no size difference within measurable limits (an
x86-64-allyesconfig build is 60(!) bytes larger with 2^31 and the incl,
but that's well within the good luck/bad luck with alignments threshold...)

As such, I'd personally prefer to leave it with 1:31:31:1 split, if
nothing else because it reads a bit tidier to me, despite the minor wart
for the incl trick.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2010-01-21 07:37    [W:0.314 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site