lkml.org 
[lkml]   [2010]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] perf_events: improve x86 event scheduling (v5)
    From
    On Thu, Jan 21, 2010 at 11:36 AM, Peter Zijlstra <peterz@infradead.org> wrote:
    > On Mon, 2010-01-18 at 10:58 +0200, Stephane Eranian wrote:
    >>  void hw_perf_enable(void)
    >>  {
    >
    >
    >> +               cpuc->n_added = 0;
    >> +               perf_events_lapic_init();
    >
    > Just wondering, why do we need that lapic_init() there?
    >
    I think I picked it up from x86_pmu_enable(). I don't think
    you necessarily need it here. Not clear to me why it was
    in x86_pmu_enable() to begin with.

    I will post a new version of the patch which fixes some bugs and
    also implements true fast path (reuse of previous assignment). It turned
    out, things were a bit more complicated than what I had in v5.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-01-21 11:45    [W:0.022 / U:2.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site