lkml.org 
[lkml]   [2010]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[26/30] i2c: Do not use device name after device_unregister
    2.6.32-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>

    commit c556752109794a5ff199b80a1673336b4df8433a upstream.

    dev_dbg outputs dev_name, which is released with device_unregister. This bug
    resulted in output like this:

    i2c Xy2�0: adapter [SMBus I801 adapter at 1880] unregistered

    The right output would be:
    i2c i2c-0: adapter [SMBus I801 adapter at 1880] unregistered

    Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/i2c/i2c-core.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/drivers/i2c/i2c-core.c
    +++ b/drivers/i2c/i2c-core.c
    @@ -801,6 +801,9 @@ int i2c_del_adapter(struct i2c_adapter *
    adap->dev.parent);
    #endif

    + /* device name is gone after device_unregister */
    + dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name);
    +
    /* clean up the sysfs representation */
    init_completion(&adap->dev_released);
    device_unregister(&adap->dev);
    @@ -813,8 +816,6 @@ int i2c_del_adapter(struct i2c_adapter *
    idr_remove(&i2c_adapter_idr, adap->nr);
    mutex_unlock(&core_lock);

    - dev_dbg(&adap->dev, "adapter [%s] unregistered\n", adap->name);
    -
    /* Clear the device structure in case this adapter is ever going to be
    added again */
    memset(&adap->dev, 0, sizeof(adap->dev));

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-01-21 05:29    [W:0.023 / U:0.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site