Messages in this thread | | | Date | Wed, 20 Jan 2010 15:03:43 -0800 (PST) | Subject | Re: [PATCH 4/9] net/sctp: Eliminate useless code | From | David Miller <> |
| |
From: Vlad Yasevich <vladislav.yasevich@hp.com> Date: Wed, 20 Jan 2010 13:10:10 -0500
> > > Julia Lawall wrote: >> From: Julia Lawall <julia@diku.dk> >> >> The variable newinet is initialized twice to the same (side effect-free) >> expression. Drop one initialization. >> >> A simplified version of the semantic match that finds this problem is: >> (http://coccinelle.lip6.fr/) >> >> // <smpl> >> @forall@ >> idexpression *x; >> identifier f!=ERR_PTR; >> @@ >> >> x = f(...) >> ... when != x >> ( >> x = f(...,<+...x...+>,...) >> | >> * x = f(...) >> ) >> // </smpl> >> >> Signed-off-by: Julia Lawall <julia@diku.dk> > > Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Julia, just like patch #3 this one had the missing final line of the patch corrupting it, so you'll need to resubmit.
| |