lkml.org 
[lkml]   [2010]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC][PATCH] PM / Runtime: Add sysfs switch for disabling device run-time PM
Date
On Wednesday 20 January 2010, Greg KH wrote:
> On Mon, Jan 18, 2010 at 01:29:55AM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > Subject: PM / Runtime: Add sysfs switch for disabling device run-time PM
> >
> > Add new device sysfs attribute, power/runtime, allowing the user
> > space to block the run-time power management of the device. If this
> > attribute is set to "disabled", the driver of the device won't be
> > able to enable run-time power management for it (without breaking the
> > rules).
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> > drivers/base/power/power.h | 4 +
> > drivers/base/power/runtime.c | 107 +++++++++++++++++++++++++++++++++----------
> > drivers/base/power/sysfs.c | 46 ++++++++++++++++++
> > include/linux/pm.h | 1
> > include/linux/pm_runtime.h | 11 +---
> > 5 files changed, 139 insertions(+), 30 deletions(-)
>
> You forgot to also add an entry into Documentation/ABI/ for when you
> add/change a sysfs file :)

There's no description for /sys/devices/.../power/wakeup in there too and
that one has been present for quite some time already.

I'd prefer adding them both in a separate patch if you don't mind.

Rafael


\
 
 \ /
  Last update: 2010-01-20 21:57    [W:0.180 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site