Messages in this thread | | | Date | Wed, 20 Jan 2010 12:00:31 +0100 | Subject | Re: [PATCH] asm-generic: dma: Add BUG_ON for uninitialized dma_ops | From | Geert Uytterhoeven <> |
| |
On Wed, Jan 20, 2010 at 11:48, Alexey Dobriyan <adobriyan@gmail.com> wrote: > On Wed, Jan 20, 2010 at 12:08 PM, <monstr@monstr.eu> wrote: >> From: Michal Simek <monstr@monstr.eu> >> >> Check that dma_ops are initialized correctly. Without this >> checking you get kernel fault and you don't know where the problem is. > > Oh, yes you do. PC will be of some small value.
And the backtrace will tell you where to look...
>> + BUG_ON(!ops); >> BUG_ON(!valid_dma_direction(dir)); >> addr = ops->map_page(dev, virt_to_page(ptr),
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |