Messages in this thread | | | From | "Zheng, Shaohui" <> | Date | Tue, 19 Jan 2010 16:33:08 +0800 | Subject | RE: [PATCH-RESEND v4] memory-hotplug: create /sys/firmware/memmap entry for new memory |
| |
I did some investigation for my patch, I see that there is an error when I make v4 patch from v3, I change the function firmware_map_add_early() by carelessness, The code entry = alloc_bootmem(sizeof(struct firmware_map_entry)); was changed to entry = kmalloc(sizeof(struct firmware_map_entry), GFP_ATOMIC);
The modification from v3 to v4 is minor, so I did not do full testing for v4 patch, I apologize for my fault.
The patch works after I correct the this code. I will resend it.
Thanks & Regards, Shaohui
-----Original Message----- From: Andrew Morton [mailto:akpm@linux-foundation.org] Sent: Saturday, January 16, 2010 6:38 AM To: Zheng, Shaohui Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org; ak@linux.intel.com; y-goto@jp.fujitsu.com; Dave Hansen; Wu, Fengguang; x86@kernel.org Subject: Re: [PATCH-RESEND v4] memory-hotplug: create /sys/firmware/memmap entry for new memory
On Mon, 11 Jan 2010 10:00:11 +0800 "Zheng, Shaohui" <shaohui.zheng@intel.com> wrote:
> memory-hotplug: create /sys/firmware/memmap entry for hot-added memory > > Interface firmware_map_add was not called in explict, Remove it and add function > firmware_map_add_hotplug as hotplug interface of memmap. > > When we hot-add new memory, sysfs does not export memmap entry for it. we add > a call in function add_memory to function firmware_map_add_hotplug. > > Add a new function add_sysfs_fw_map_entry to create memmap entry, it can avoid > duplicated codes.
The patch causes an early exception in kmem_cache_alloc_notrace() - probably due to a null cache pointer.
config: http://master.kernel.org/~akpm/config-akpm2.txt
| |