lkml.org 
[lkml]   [2010]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] MIPS: cleanup switches with cases that can be merged
Roel Kluin wrote:
> I did a search for switch statements with cases that can be merged, but maybe
> some were not intended?
> ---------------->8------------------------------------------8<-----------------
> In these cases the same code was executed.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> arch/mips/include/asm/octeon/octeon-feature.h | 8 ++------
> arch/mips/kernel/cpu-probe.c | 3 ---
> arch/mips/math-emu/ieee754dp.c | 1 -
> arch/mips/math-emu/ieee754sp.c | 1 -
> arch/mips/pci/pci-octeon.c | 6 ++----
> arch/mips/powertv/asic/asic_devices.c | 4 ----
> arch/mips/sgi-ip32/ip32-irq.c | 9 +--------
> 7 files changed, 5 insertions(+), 27 deletions(-)

This patch should be split up.

Octeon, PowerTV, and IP32 are all different architectures. They should
be in their own patches.

The two math-emu parts could probably go together.

cpu-probe seems like its own thing.

This brings us to the larger question: This is just code churn. Is it
even worthwhile?


David Daney





\
 
 \ /
  Last update: 2010-01-20 03:05    [W:3.526 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site