Messages in this thread | | | Date | Tue, 19 Jan 2010 10:44:55 -0500 | Subject | Re: ppp_generic.c severly whitespace damanged by 9c705260feea6ae329bc6b6d5f6d2ef0227eda0a | From | (Lennart Sorensen) |
| |
On Tue, Jan 19, 2010 at 02:13:01AM -0800, David Miller wrote: > From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen) > Date: Mon, 18 Jan 2010 17:59:55 -0500 > > > I was just looking at ppp_generic, and noticed that it fairly recently > > (as in the last year) got rather mangled with many spaces turned into tabs > > in places they very much shouldn't have been. I tracked it down to commit > > 9c705260feea6ae329bc6b6d5f6d2ef0227eda0a (ppp: ppp_mp_explode() redesign). > > > > I am amazed if that patch passed the patch checking script. I have no > > idea what kind of weird editor setting did this, but it has to have been a > > weird editor setting or a very unfortunate search and replace gone wrong. > > I only found it trying to apply a patch I was playing with and wondering > > why it wouldn't apply. Then I found there were tabs in the middle of > > comments that used to be spaces. > > > > Well here is a patch that should fix it up as far as I can tell. > > > > Purely whitespace repair. No actual code changes. > > > > Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca> > > I'm probably responsible for not catching this sorry. > > Applied to net-next-2.6, thanks.
Great. I hope I got them all. I couldn't find anymore searching though.
-- Len Sorensen
| |