Messages in this thread | | | Date | Tue, 19 Jan 2010 14:26:57 +0000 | From | Alan Cox <> | Subject | Re: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes" causes gobi_loader to hang |
| |
> The log shows no call to usb_serial_generic_write_room() > Do you consider this a bug in the tty layer?
Actually this all makes sense because of where it was hanging. A reply of 0 to the tty->ops->write will cause it to either return (O_NONBLOCK) or sleep in the n_tty write code waiting for a write_wait wakeup (tty_wakeup(tty))
So the fix does indeed look correct.
| |