lkml.org 
[lkml]   [2010]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [REGRESSION] "USB: use kfifo to buffer usb-generic serial writes" causes gobi_loader to hang
    Date
    Am Dienstag, 19. Januar 2010 14:29:34 schrieb Alan Cox:
    > On Tue, 19 Jan 2010 14:20:29 +0100
    > Oliver Neukum <oliver@neukum.org> wrote:
    >
    > > Am Montag, 18. Januar 2010 21:14:16 schrieb Matthew Garrett:
    > >
    > > > drivers/usb/serial/generic.c: usb_serial_generic_write - port 0, 1565
    > > > bytes
    > > > drivers/usb/serial/generic.c: usb_serial_generic_write - put 0 bytes
    > > > into fifo
    > > > drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback -
    > > > port 0
    > >
    > > If the FIFO is full we can do nothing. Please try the attached patch.
    >
    > If the FIFO is full how are we getting called - we should have throttled
    > earlier if there is any flow control (including 'look no URBs' cases) ?

    The log shows no call to usb_serial_generic_write_room()
    Do you consider this a bug in the tty layer?

    Regards
    Oliver


    \
     
     \ /
      Last update: 2010-01-19 14:59    [W:0.022 / U:0.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site