lkml.org 
[lkml]   [2010]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] atmel uaba : Adding invert vbus_pin
On Mon, Jan 18, 2010 at 08:02:46AM +0100, Eirik Aanonsen wrote:
> >
> > On Mon, Jan 04, 2010 at 02:01:59PM +0100, Eirik Aanonsen wrote:
> > > Adding vbus_pin_inverted so that the usb detect pin can be active
> > high or low.
> > > This because depending on HW implementation it is better to have
> > active low.
> > > Also replaced the pio_get_value(udc->vbus_pin); with a call to
> > vbus_is_present(udc);
> > >
> > > Signed-off-by: Eirik Aanonsen <eaa@wprmedical.com>
> >
> > Please always run your patches through 'scripts/checkpatch.pl' before
> > sending them so that you don't accidentally add coding style errors.
> >
> > thanks,
> >
> > greg k-h
>
> Yes I'm sorry I got that feedback from several others as well.
>
> That is why I resubmitted the patch on 05.Jan. But under the same name, and since then I have not received any feedback on that patch.
>
> ***
> Snip from local:
>
> ./scripts/checkpatch.pl 0014-Adding-vbus_pin_inverted-so-that-the-usb-detect-pin.patch
> total: 0 errors, 0 warnings, 38 lines checked
>
> 0014-Adding-vbus_pin_inverted-so-that-the-usb-detect-pin.patch has no obvious style problems and is ready for submission.
> ***

I don't see it in my queue, care to resend?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-01-19 05:53    [W:0.072 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site