Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 2/3][v2] vmstat: add anon_scan_ratio field to zoneinfo | Date | Mon, 18 Jan 2010 11:24:51 +0900 (JST) |
| |
> On 01/17/2010 09:10 PM, Minchan Kim wrote: > > > Absoultely right. I missed that. Thanks. > > get_scan_ratio used lru_lock to get reclaim_stat->recent_xxxx. > > But, it doesn't used lru_lock to get ap/fp. > > > > Is it intentional? I think you or Rik know it. :) > > I think if we want to get exact value, we have to use lru_lock until > > getting ap/fp. > > If it isn't, we don't need lru_lock when we get the reclaim_stat->recent_xxxx. > > > > What do you think about it? > > This is definately not intentional.
Really? So, I'll post next patch.
Thanks.
> Getting race conditions in this code could throw off the > statistics by a factor 2. I do not know how serious that > would be for the VM or whether (and how quickly) it would > self correct. > > -- > All rights reversed.
| |