lkml.org 
[lkml]   [2010]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 6/6] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos
    Date
    KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:

    >> BTW, another concern by negative "pos" value is, the following like code
    >>
    >> pos >> shift_bits
    >>
    >> it will break the above. So, I think it should be checked if not yet.
    >
    > Where do we check ?
    >
    > FMODE_NEG_OFFSET is just used by /dev/mem and /proc/<pid>/mem. And I don't
    > think there are no additonal users. So, I myself don't have has such concerns...

    Sorry, it's just my concern. I'm not checking real path (e.g. vfs) of
    related to /dev/mem, if there is no user of such code, it's ok.

    Thanks.
    --
    OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>


    \
     
     \ /
      Last update: 2010-01-18 03:01    [W:0.047 / U:60.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site