lkml.org 
[lkml]   [2010]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:tracing/urgent] tracing/filters: Add comment for match callbacks
    Commit-ID:  d1303dd1d6b220cab375f24fa91a5640e54e169e
    Gitweb: http://git.kernel.org/tip/d1303dd1d6b220cab375f24fa91a5640e54e169e
    Author: Li Zefan <lizf@cn.fujitsu.com>
    AuthorDate: Thu, 14 Jan 2010 10:54:40 +0800
    Committer: Steven Rostedt <rostedt@goodmis.org>
    CommitDate: Thu, 14 Jan 2010 22:38:14 -0500

    tracing/filters: Add comment for match callbacks

    We should be clear on 2 things:

    - the length parameter of a match callback includes
    tailing '\0'.

    - the string to be searched might not be NULL-terminated.

    Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
    LKML-Reference: <4B4E8770.7000608@cn.fujitsu.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    kernel/trace/trace_events_filter.c | 13 ++++++++++++-
    1 files changed, 12 insertions(+), 1 deletions(-)

    diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
    index 60c2a4e..e42af9a 100644
    --- a/kernel/trace/trace_events_filter.c
    +++ b/kernel/trace/trace_events_filter.c
    @@ -252,7 +252,18 @@ static int filter_pred_none(struct filter_pred *pred, void *event,
    return 0;
    }

    -/* Basic regex callbacks */
    +/*
    + * regex_match_foo - Basic regex callbacks
    + *
    + * @str: the string to be searched
    + * @r: the regex structure containing the pattern string
    + * @len: the length of the string to be searched (including '\0')
    + *
    + * Note:
    + * - @str might not be NULL-terminated if it's of type DYN_STRING
    + * or STATIC_STRING
    + */
    +
    static int regex_match_full(char *str, struct regex *r, int len)
    {
    if (strncmp(str, r->pattern, len) == 0)

    \
     
     \ /
      Last update: 2010-01-16 10:47    [W:0.023 / U:209.988 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site