lkml.org 
[lkml]   [2010]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver
From
From: "Ha, Tristram" <Tristram.Ha@Micrel.Com>
Date: Fri, 15 Jan 2010 18:57:59 -0800

> The KSZ8842 has a switch with lots of hardware configurations. The =
> driver uses the proc system to allow users to configure the switch. If =
> this is not desired the whole thing can be removed by not calling the =
> init_proc() function.

I think there needs to be a serious discussion about how
this driver uses bridge layer internals by doing things like:

+/* Needed for STP support. */
+#ifdef CONFIG_KSZ8842_STP
+#include <../net/bridge/br_private.h>
+#endif

and uses procfs to configure the ports.

Stephen please look this over and make suggestions for better
ways to support and configure these kinds of devices.

Thanks.


\
 
 \ /
  Last update: 2010-01-16 10:23    [W:0.095 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site