Messages in this thread | | | From | Jeff Moyer <> | Subject | Re: [PATCH]cfq-iosched: don't take requests with long distence as close | Date | Fri, 15 Jan 2010 14:45:50 -0500 |
| |
Corrado Zoccolo <czoccolo@gmail.com> writes:
> Hi Jeff, > I think this patch has the same flaw as Shaohua's. > The seekiness check that you introduce in cfq_rq_close is already > present in its caller, cfq_close_cooperator, so it is not effective.
I don't think so. There are two queues, here. One queue is checked by the caller, and that is the cur_cfqq. The __cfqq needs to also be checked.
> Up to now, the only patch that improves this situation is the one that > changes the unmerge policy to unmerge after a single time slice.
Yes, I definitely agree with that, and I think that patch should go in.
Cheers, Jeff
| |