Messages in this thread | | | Date | Fri, 15 Jan 2010 08:56:06 +0800 | From | Zhenyu Wang <> | Subject | Re: [Stable-review] [PATCH 15/52] drm: remove address mask param for drm_pci_alloc() |
| |
On 2010.01.14 15:45:16 -0800, Greg KH wrote: > On Thu, Jan 14, 2010 at 11:38:48PM +0000, Ben Hutchings wrote: > > On Thu, 2010-01-14 at 14:26 -0800, Greg Kroah-Hartman wrote: > > > From: Zhenyu Wang <zhenyu.z.wang@intel.com> > > > > > > commit e6be8d9d17bd44061116f601fe2609b3ace7aa69 upstream. > > > > > > drm_pci_alloc() has input of address mask for setting pci dma > > > mask on the device, which should be properly setup by drm driver. > > > And leave it as a param for drm_pci_alloc() would cause confusion > > > or mistake would corrupt the correct dma mask setting, as seen on > > > intel hw which set wrong dma mask for hw status page. So remove > > > it from drm_pci_alloc() function. > > > > Based on comments at <http://bugs.freedesktop.org/show_bug.cgi?id=25510> > > I think we also need this fix: > > > > commit fc61901373987ad61851ed001fe971f3ee8d96a3 > > Author: David Woodhouse <dwmw2@infradead.org> > > Date: Wed Dec 2 11:00:05 2009 +0000 > > > > agp/intel-agp: Clear entire GTT on startup > > > > Ben. > > Ok, I can add that as well, if the Intel / DRM people do not object. > > Anyone? >
yeah, please add that one too, it's an important fix.
thanks.
-- Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 [unhandled content-type:application/pgp-signature] | |