lkml.org 
[lkml]   [2010]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] [PATCH 7/7] Ftrace plugin for Uprobes
From
Date
On Thu, 2010-01-14 at 12:35 +0100, Frederic Weisbecker wrote:
> On Thu, Jan 14, 2010 at 12:23:11PM +0100, Peter Zijlstra wrote:
> > On Mon, 2010-01-11 at 17:56 +0530, Srikar Dronamraju wrote:
> > > This patch implements ftrace plugin for uprobes.
> >
> > Right, like others have said, trace events is a much saner interface.
> >
> > So the easiest way I can see that working is to register uprobes against
> > a file (not a pid). Then on creation it uses rmap to find all current
> > maps of that file and install the probe if there is a consumer for that
> > map.
> >
> > Then for each new mmap() of that file, we also need to check if there's
> > a consumer ready and install the probe.
>
>
>
> That looks racy.
>
> Say you first create a probe on /bin/ls:
>
> perf probe p addr_in_ls /bin/ls
>
> then something else launches /bin/ls behind you, probe
> is set on it
>
> then you launch:
>
> perf record -e "probe:...." /bin/ls
>
> Then it goes recording the previous instance.

Uhm, why? Only the perf /bin/ls instance has a consumer and will thus
have a probe installed.

(Or if you want to use ftrace you need to always have all instances
probed anyway)



\
 
 \ /
  Last update: 2010-01-14 12:45    [W:0.104 / U:3.588 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site