lkml.org 
[lkml]   [2010]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -v2 5/5] x86: use dmi check to treat disabled cpus as hotplug cpus.
From
Date
On Wed, 2010-01-13 at 14:27 -0800, H. Peter Anvin wrote:
> On 01/13/2010 02:23 PM, Andi Kleen wrote:
> >> There are configurations in which percpu memory is in the megabytes.
> >
> > There used to be some like this (with some broken debug code), but they
> > got all fixed i believe to only allocate on real cpu hotplug.
> >
> > If not the right way is to fix them, not add DMI blacklists.
> >
> > Beside when you enable debug code you probably don't care about
> > a few MB too much.
> >
> >> This is exactly why we need high water mark allocation of percpu memory:
> >
> > No we just need to fix any percpu pigs (if there are really any left,
> > I did a couple of patches some time ago)
> >
> > "Don't work around broken code -- fix it"
> >
>
> Well, that *is* working around broken code, in this case the broken code
> is the percpu allocation strategy.

Andi, Recently percpu folks changed the per-cpu static first chunk to
PMD SIZE right. I think that is what causing all this issue.

thanks,
suresh



\
 
 \ /
  Last update: 2010-01-13 23:33    [W:0.046 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site