lkml.org 
[lkml]   [2010]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Changelog quality
On Wed, 13 Jan 2010, Stefan Richter wrote:

> If it was by mistake, inclusion of the find-and-replace script into the
> patch posting *after the --- delimiter* might have increased the chance
> that a patch reviewer becomes aware of a possible error source
> (inadequate match patterns...). So that could be useful during review
> before commit, but not so much if the change is revisited some time
> after commit.

Somewhat tangentially, it's worth mentioning that the comments
appearing after the "---" delimiter exist only in the original patch
submissions, not in the final commits. Hence they are not available to
anyone reviewing the changes after acceptance.

It would be nice if there was a way to link automatically a git commit
to an archived copy of the email message in which it was originally
submitted.

Alan Stern



\
 
 \ /
  Last update: 2010-01-13 18:31    [from the cache]
©2003-2011 Jasper Spaans