Messages in this thread Patch in this message | | | Date | Wed, 13 Jan 2010 10:42:14 -0500 | From | Jeff Mahoney <> | Subject | Re: [patch 2/6] hugetlb: Fix section mismatches |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/13/2010 10:40 AM, Lee Schermerhorn wrote: > On Tue, 2010-01-12 at 19:48 -0500, Jeff Mahoney wrote: >> plain text document attachment (patches.rpmify) >> hugetlb_register_node calls hugetlb_sysfs_add_hstate, which is marked with >> __init. Since hugetlb_register_node is only called by >> hugetlb_register_all_nodes, which in turn is only called by hugetlb_init, >> it's safe to mark both of them as __init. > > Actually, hugetlb_register_node() also called, via a function pointer > that hugetlb registers with the sysfs node driver, when a node is hot > plugged. So, I think the correct approach is to remove the '__init' > from hugetlb_sysfs_add_hstate() as this is also used at runtime. I > missed this in the original submittal.
Yep. You're right. Sorry for the noise.
- -Jeff
> Regards, > Lee Schermerhorn > >> >> Signed-off-by: Jeff Mahoney <jeffm@suse.com> >> --- >> mm/hugetlb.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> --- a/mm/hugetlb.c >> +++ b/mm/hugetlb.c >> @@ -1630,7 +1630,7 @@ void hugetlb_unregister_node(struct node >> * hugetlb module exit: unregister hstate attributes from node sysdevs >> * that have them. >> */ >> -static void hugetlb_unregister_all_nodes(void) >> +static void __init hugetlb_unregister_all_nodes(void) >> { >> int nid; >> >> @@ -1650,7 +1650,7 @@ static void hugetlb_unregister_all_nodes >> * Register hstate attributes for a single node sysdev. >> * No-op if attributes already registered. >> */ >> -void hugetlb_register_node(struct node *node) >> +void __init hugetlb_register_node(struct node *node) >> { >> struct hstate *h; >> struct node_hstate *nhs = &node_hstates[node->sysdev.id]; >> >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> >
- -- Jeff Mahoney SUSE Labs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/
iEYEARECAAYFAktN6dYACgkQLPWxlyuTD7JzEgCfXZKyPnW9VKO7OTatSm5k5WSI l6sAoIVB0cTvz1AwN2mG7ANGPt6VVuTi =TYGp -----END PGP SIGNATURE-----
| |