Messages in this thread | | | Date | Wed, 13 Jan 2010 06:03:35 -0500 | From | William Allen Simpson <> | Subject | Re: [PATCH 1/2] net: tcp_header_len_th and tcp_option_len_th |
| |
Eric Dumazet wrote: 2) You also should know that sizeof() is *strongly* typed (size_t), > not an "untyped constant". > My apologies, it's fairly early in the morning here -- I meant "unsigned" rather than "untyped".
> The (int) cast it not only _not_ needed, its also confusing. > I'm sorry for your confusion. I believe it adds clarity.
Moreover, it's fairly egregious that the old tcp_hdrlen() contributor didn't take signed versus unsigned into account.
Perhaps we could move along to more substantive issues....
Have you had an opportunity to test PATCH 2/2 in this series?
| |