Messages in this thread | | | Subject | Re: [PATCH]drivers/mtd/chips/cfi_probe.c:18 remove unneeded comment | From | Artem Bityutskiy <> | Date | Wed, 13 Jan 2010 07:32:45 +0200 |
| |
On Thu, 2010-01-07 at 23:18 +0100, René Bolldorf wrote: > --- ./drivers/mtd/chips/cfi_probe.c 2009-12-28 21:09:46.638828686 +0100 > +++ ./drivers/mtd/chips/cfi_probe.c 2010-01-04 22:38:31.536678726 +0100 > @@ -18,8 +18,6 @@ > #include <linux/mtd/cfi.h> > #include <linux/mtd/gen_probe.h> > > -//#define DEBUG_CFI > - > #ifdef DEBUG_CFI > static void print_cfi_ident(struct cfi_ident *); > #endif
I do not think this is is needed. The commented out define shows what one should do to debug the thing. Without that line it is not so obvious. So, nack from me.
-- Best Regards, Artem Bityutskiy (Артём Битюцкий)
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |