lkml.org 
[lkml]   [2010]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel
On Tue, 12 Jan 2010 16:57:40 +0800
"Zheng, Shaohui" <shaohui.zheng@intel.com> wrote:

>
> 3 points...
> 1. I think this patch cannot be compiled in archs other than x86. Right ?
> IOW, please add static inline dummy...
> [Zheng, Shaohui] Agree, I will add a static dummy function
>
> 2. pgdat->[start,end], totalram_pages etc...are updated at memory hotplug.
> Please place the hook nearby them.
> [Zheng, Shaohui] Agree.
>
> 3. I recommend you yo use memory hotplug notifier.
> If it's allowed, it will be cleaner.
> It seems there are no strict ordering to update parameters this patch touches.
>
> [Zheng, Shaohui] Kame, do you means put the hook into function slab_mem_going_online_callback, it seems a good idea. If we select this method, we will need not to update these variable in function add_memory explicitly.
>
yes. I think callback is the best.

Thanks,
-Kame



\
 
 \ /
  Last update: 2010-01-12 10:03    [W:0.051 / U:0.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site