lkml.org 
[lkml]   [2010]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Crypto test results unused?
On Tue, Jan 12, 2010 at 06:55:07PM +0100, Krzysztof Halasa wrote:
>
> Currently the /proc/crypto contains:
>
> - for passed tests: "selftest: passed" (which is of course right)
>
> - for failed tests: "selftest: unknown" (which is a surprise for me):
>
> alg: skcipher: Test 1 failed on encryption for ecb(des)-ixp4xx
> 00000000: 01 23 45 67 89 ab cd e7
>
> name : ecb(des)
> driver : ecb(des)-ixp4xx
> module : ixp4xx_crypto
> priority : 300
> refcnt : 1
> selftest : unknown
> type : ablkcipher
> async : yes
> blocksize : 8
> min keysize : 8
> max keysize : 8
> ivsize : 0
> geniv : <default>

This is fine.

> - for routines without a test: "selftest: passed" (which isn't true
> either)
>
> alg: No test for authenc(hmac(md5),cbc(des)) (authenc(hmac(md5),cbc(des))-ixp4xx)

This should be fixed by adding some code to test authenc algorithms
by combining the test vectors of its components.

> I think we need a way to differentiate between "really unknown" and
> "failed", do we need another flag for it?

It doesn't matter. We test all algorithms at registration time.
So unknown means failed except during registration.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2010-01-12 23:47    [W:0.068 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site