Messages in this thread | | | From | "Zheng, Shaohui" <> | Date | Tue, 12 Jan 2010 21:17:40 +0800 | Subject | RE: [ RESEND PATCH v3] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel |
| |
> > 3 points... > 1. I think this patch cannot be compiled in archs other than x86. Right ? > IOW, please add static inline dummy... > [Zheng, Shaohui] Agree, I will add a static dummy function > > 2. pgdat->[start,end], totalram_pages etc...are updated at memory hotplug. > Please place the hook nearby them. > [Zheng, Shaohui] Agree. > > 3. I recommend you yo use memory hotplug notifier. > If it's allowed, it will be cleaner. > It seems there are no strict ordering to update parameters this patch touches. > > [Zheng, Shaohui] Kame, do you means put the hook into function slab_mem_going_online_callback, it seems a good idea. If we select this method, we will need not to update these variable in function add_memory explicitly. > yes. I think callback is the best. [Zheng, Shaohui] Kame, I check the code carefully and write a simple patch, I found the callback will never be executed. The only entrance of this callback is in function online_pages/offline_pages, but I did not found explicit call to these 2 functions. Do we need to add a memory_notify to trigger this callback in function add_memory?
Thanks, -Kame
Thanks & Regards, Shaohui
| |