Messages in this thread |  | | Date | Mon, 11 Jan 2010 11:51:42 +0100 | From | Patrick McHardy <> | Subject | Re: [PATCH v2 5/8] net/ipv4/netfilter/nf_nat_ftp.c: Remove (*mangle[]) array and functions, use %pI4 |
| |
Joe Perches wrote: > These functions merely exist to format a buffer and call > nf_nat_mangle_tcp_packet. > > Format the buffer and perform the call in nf_nat_ftp instead. > > Use %pI4 for the IP address. > > Saves ~600 bytes of text > > old: > $ size net/ipv4/netfilter/nf_nat_ftp.o > text data bss dec hex filename > 2187 160 408 2755 ac3 net/ipv4/netfilter/nf_nat_ftp.o > new: > $ size net/ipv4/netfilter/nf_nat_ftp.o > text data bss dec hex filename > 1532 112 288 1932 78c net/ipv4/netfilter/nf_nat_ftp.o
Applied, thanks. BTW, its enough to CC netfilter-devel and optionally netdev on patches, netfilter and netfilter-core are unnecessary.
|  |