Messages in this thread | | | Date | Mon, 11 Jan 2010 11:15:43 +0100 | From | Ralf Baechle <> | Subject | Re: [PATCH] mips,mm: Reinstate move_pte optimization |
| |
On Thu, Jan 07, 2010 at 03:32:57PM +0900, KOSAKI Motohiro wrote:
> > to include/linux/mm.h - I'd prefer to keep it private if we can. > > But for completeness, this would involve resurrecting the 2.6.19 > > MIPS move_pte(), which makes sure mremap() move doesn't interfere > > with our assumptions. Something like > > > > #define __HAVE_ARCH_MOVE_PTE > > pte_t move_pte(pte_t pte, pgprot_t prot, unsigned long old_addr, > > unsigned long new_addr) > > { > > if (pte_present(pte) && is_zero_pfn(pte_pfn(pte))) > > pte = mk_pte(ZERO_PAGE(new_addr), prot); > > return pte; > > } > > > > in arch/mips/include/asm/pgtable.h. > > I agree with resurrecting mips move_pte. At least your patch > passed my cross compile test :) > > Ralf, can you please review following patch?
Looks good.
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Thanks,
Ralf
| |