Messages in this thread | | | Date | Mon, 11 Jan 2010 16:55:45 -0800 | Subject | Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset() | From | Marc Bejarano <> |
| |
2010/1/11 René Bolldorf <xsecute@googlemail.com>: > I hope that's good enough explained :-).
definitely an improvement, but i think jeff is going to want your S-O-B and at least a patch title, if no description :)
> + /* make sure sense_buf is cleared then atapi_eh_request_sense is > called.
s/then/when/ ?
> + * (to make sure nothing get's reused.)
probably not necessary
> + * thanks to James Bottomley
this may be better in a patch description
cheers, marc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |