lkml.org 
[lkml]   [2010]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] netpoll: allow execution of multiple rx_hooks per interface
From
Date
On Mon, 2010-01-11 at 15:59 -0800, David Miller wrote:
> From: Matt Mackall <mpm@selenic.com>
> Date: Mon, 11 Jan 2010 17:21:48 -0600
>
> > Looks pretty good. Dave?
> >
> > Acked-by: Matt Mackall <mpm@selenic.com>
>
> I don't like the loop for RX ARP processing.
>
> The packet contents aren't going to change, so doing basic
> packet validation inside of the "for each RX client" loop
> of arp_reply() doesn't make any sense.

True. Dan, please help our poor compilers with some manual loop
invariant motion.

--
http://selenic.com : development and support for Mercurial and Linux




\
 
 \ /
  Last update: 2010-01-12 01:07    [W:0.040 / U:10.616 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site