Messages in this thread | | | Date | Mon, 11 Jan 2010 15:59:12 -0800 (PST) | Subject | Re: [PATCH] netpoll: allow execution of multiple rx_hooks per interface | From | David Miller <> |
| |
From: Matt Mackall <mpm@selenic.com> Date: Mon, 11 Jan 2010 17:21:48 -0600
> Looks pretty good. Dave? > > Acked-by: Matt Mackall <mpm@selenic.com>
I don't like the loop for RX ARP processing.
The packet contents aren't going to change, so doing basic packet validation inside of the "for each RX client" loop of arp_reply() doesn't make any sense.
| |