lkml.org 
[lkml]   [2010]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] OMAP: dma_chan[lch_head].flag & OMAP_DMA_ACTIVE tested twice in omap_dma_unlink_lch()
* Roel Kluin <roel.kluin@gmail.com> [100109 05:49]:
> The same flag and bits were tested twice.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> arch/arm/plat-omap/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Is this what was intended? please review.

Thanks, nice catch. Will queue into omap-fixes.

Regards,

Tony

> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> index 09d82b3..728c642 100644
> --- a/arch/arm/plat-omap/dma.c
> +++ b/arch/arm/plat-omap/dma.c
> @@ -1183,7 +1183,7 @@ void omap_dma_unlink_lch(int lch_head, int lch_queue)
> }
>
> if ((dma_chan[lch_head].flags & OMAP_DMA_ACTIVE) ||
> - (dma_chan[lch_head].flags & OMAP_DMA_ACTIVE)) {
> + (dma_chan[lch_queue].flags & OMAP_DMA_ACTIVE)) {
> printk(KERN_ERR "omap_dma: You need to stop the DMA channels "
> "before unlinking\n");
> dump_stack();


\
 
 \ /
  Last update: 2010-01-12 00:17    [W:0.027 / U:0.200 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site