lkml.org 
[lkml]   [2010]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-2.6 alt.3] af_packet: Don't use skb after dev_queue_xmit()
On Mon, Jan 11, 2010 at 05:30:45PM -0500, Michael Breuer wrote:
> On 1/11/2010 3:04 AM, Jarek Poplawski wrote:
...
> >----------------> (alternative 3)
> >
> >Subject: af_packet: Don't use skb after dev_queue_xmit()
> >
> >tpacket_snd() can change and kfree an skb after dev_queue_xmit(),
> >which is illegal.
> >
> >With debugging by: Stephen Hemminger<shemminger@vyatta.com>
> >
> >Reported-by: Michael Breuer<mbreuer@majjas.com>
> >Signed-off-by: Jarek Poplawski<jarkao2@gmail.com>
> >
> >Cc: Stephen Hemminger<shemminger@vyatta.com>
> >---
> >
> > net/packet/af_packet.c | 19 ++++++++++++++-----
> > 1 files changed, 14 insertions(+), 5 deletions(-)
...
> Tested by: Michael Breuer
>
> Note: This patch is delivering better ethernet throughput (15-20%)
> and no than the previous two patches. I'm also no longer seeing
> dropped RX packets. Good work!

David, if this patch is acceptable now, please add:

With help from: David S. Miller <davem@davemloft.net>

Tested-by: Michael Breuer<mbreuer@majjas.com>

Thanks everybody,
Jarek P.


\
 
 \ /
  Last update: 2010-01-11 23:51    [W:0.032 / U:33.112 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site