Messages in this thread | | | Date | Mon, 11 Jan 2010 23:51:49 +0300 | From | Cyrill Gorcunov <> | Subject | Re: introduce NMI_AUTO as nmi_watchdog option |
| |
On Mon, Jan 11, 2010 at 03:33:56PM -0500, Don Zickus wrote: > On Mon, Jan 11, 2010 at 11:27:29PM +0300, Cyrill Gorcunov wrote: > > On Mon, Jan 11, 2010 at 02:16:33PM -0500, Don Zickus wrote: > > > Hi Ingo, > > > > > ... > > > I was going to jump in and try to do this work. I wanted to make sure > > > what you were looking for here. When you say convert nmi watchdog to perf > > > events, I assume you mean merging over the bits of perfctr-watchdog.c to > > > perf_events.c, modify nmi.c to just register as a normal perf event and > > > probably cleanup the oprofile stuff to match, correct? > > > > > > Cheers, > > > Don > > > > > > > As far as I know -- converting perfctr-watchdog.c to into perfevents > > style would be quite a desirable feature. But I still didn't manage to > > find time for this task :( If you're interested to start this work > > -- that would be just great! > > After looking through the code I just had some questions, perhaps you have > thought about this longer than me, what to do with the reservation code > (just remove it I assume and let perf_events _be_ the only code that > handles perf events) and what to do with some of the cpu quirks as noted > in perfctr-watchdog.c (notable some of the Intel errata for the Core > chipsets). > > Cheers, > Don >
Hi Don,
well I must admit I didn't look too close to this code (if I had I would have sent some patch for review at least :). But I was suggested to take a look on hw_breakpoint.c (Frederic worked on it iirc, CC'ed) as an example of perfevent'ed code. So converting to perf-event is not trivial task and I fear I can't give any useful advice at moment since as I said I didn't manage to find time for this task and as result didn't read code byte-to-byte, sorry. But if I get some idea -- will share!
-- Cyrill
| |