lkml.org 
[lkml]   [2010]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/7] sysfs: Pack sysfs_dirent more tightly.
    Date
    From: Eric W. Biederman <ebiederm@aristanetworks.com>

    Placing the 16bit s_mode between a pointer and a long doesn't pack well
    especailly on 64bit where we wast 48 bits. So move s_mode and
    declare it as a unsigned short. This is the sysfs backing store
    after all we don't need fields extra large just in case someday
    we want userspace to be able to use a larger value.

    Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
    ---
    fs/sysfs/sysfs.h | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/fs/sysfs/sysfs.h b/fs/sysfs/sysfs.h
    index cdd9377..0417805 100644
    --- a/fs/sysfs/sysfs.h
    +++ b/fs/sysfs/sysfs.h
    @@ -66,8 +66,8 @@ struct sysfs_dirent {
    };

    unsigned int s_flags;
    + unsigned short s_mode;
    ino_t s_ino;
    - umode_t s_mode;
    struct sysfs_inode_attrs *s_iattr;
    };

    --
    1.6.5.2.143.g8cc62


    \
     
     \ /
      Last update: 2010-01-11 21:25    [W:0.020 / U:1.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site