Messages in this thread | | | Date | Mon, 11 Jan 2010 15:26:58 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] [1/9] Add rcustring ADT for RCU protected strings v2 |
| |
On Mon, Jan 11, 2010 at 01:12:41PM +0100, Bert Wesarg wrote: > On Tue, Jan 5, 2010 at 03:15, Andi Kleen <andi@firstfloor.org> wrote: > > Index: linux-2.6.33-rc2-ak/lib/rcustring.c > > =================================================================== > > --- /dev/null > > +++ linux-2.6.33-rc2-ak/lib/rcustring.c > > [ . . . ] > > > +/* > > + * Get a local private copy of a RCU protected string. > > + * Mostly useful to get a string that is stable while sleeping. > > + * Caller must free returned string. > > + */ > > +char *access_rcu_string(char **str, int size, gfp_t gfp) > > +{ > > + char *copy = kmalloc(size, gfp); > No check of return value from kmalloc()? > > > + if (!str) > > + return NULL;
The !str should be !copy right. I fixed that in my version. Thanks for catching.
-Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |