lkml.org 
[lkml]   [2010]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [uClinux-dev] [PATCH] Valid relocation symbol for FLAT format on ARM, v2
Date
On Thursday 31 December 2009 20:26:45 Jun Sun wrote:

when posting updates, you should put the "v2" and such inside of the "[patch]"
marker like so: [PATCH v2]. git will remove this automatically when applying.

> #define flat_old_ram_flag(flags) (flags)
> -#define flat_reloc_valid(reloc, size) ((reloc) <= (size))
> +#define flat_reloc_valid(reloc, size) ((reloc) <= (size) + 0x1000)
> +/* [jsun] new gcc 4.x generates ANCHOR symbols in order to reduce the size

comments go above the thing they're documenting, not below. the "[jsun]" is
also not really useful -- no one who reads this after the fact will have any
idea what "[jsun]" means.
-mike
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-01-01 07:27    [W:0.074 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site