lkml.org 
[lkml]   [2009]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] tracing: Add sysctl to enable/disable tracing on oops
    From
    Date
    On Wed, 2009-09-09 at 09:47 +0800, Li Zefan wrote:
    > Steven Rostedt wrote:
    > > On Wed, 2009-09-09 at 09:37 +0800, Li Zefan wrote:
    > >> Steven Rostedt wrote:
    > >>> On Wed, 2009-09-09 at 09:15 +0800, Li Zefan wrote:
    > >>>> Currently we always disable tracing on oops, and this patch
    > >>>> adds a sysctl so one can choose to enable it.
    > >>> Hmm, we already have a way to enable it.
    > >>>
    > >>> # echo 1 > /debug/tracing/tracing_on
    > >>>
    > >> What I want is a way to not disable it when an oops happened. :)
    > >>
    > >
    > > Ah, I misunderstood. May I ask a silly question?
    > >
    > > Why?
    > >
    >
    > Otherwise we won't get trace output from trae_crash_kexec if
    > crash_kexec() is not called by panic(). For example:
    >
    > oops_begin()
    > ->trace_off()
    > ->panic_on_oops
    > ->kexec_should_crash()
    > ->crash_kexec()

    OK, but I'm not exactly sure what you final goal is here. To have a
    something to search for in the ring buffer after the crash? Maybe
    instead we can add a "trace_oops" event? Just put it before the
    tracing_off call.

    -- Steve




    \
     
     \ /
      Last update: 2009-09-09 04:07    [W:0.020 / U:61.384 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site