Messages in this thread | | | Date | Tue, 08 Sep 2009 21:19:33 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH #upstream-fixes] libata: fix off-by-one error in ata_tf_read_block() |
| |
On 08/16/2009 08:21 AM, Tejun Heo wrote: > ata_tf_read_block() has off-by-one error when converting CHS address > to LBA. The bug isn't very visible because ata_tf_read_block() is > used only when generating sense data for a failed RW command and CHS > addressing isn't used too often these days. > > This problem was spotted by Atsushi Nemoto. > > Signed-off-by: Tejun Heo<tj@kernel.org> > Reported-by: Atsushi Nemoto<anemo@mba.ocn.ne.jp> > --- >> Well, I expect fix by you (or other libata hackers) since I think you >> can write better warning message and changelog than me ;) > > In that case, sure. Thanks a lot for the nice spotting. :-) > > drivers/ata/libata-core.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-)
applied
| |