Messages in this thread | | | Date | Tue, 8 Sep 2009 15:06:13 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH] fix saa7134-input.c for IR controller over i2c |
| |
Em Tue, 8 Sep 2009 11:48:23 +0200 Lukáš Karas <lukas.karas@centrum.cz> escreveu:
> Hi All, > I have DVB card with IR controller connected over i2c bus (this card is > supported by module saa7134). This IR controller work mostly fine, bud when I > execute > rmmod ir-kbd-i2c and modprobe ir-kbd-i2c again, IR controller stops working. > I found problem in aa7134-input.c, metod saa7134_probe_i2c_ir.
> #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30) > memset(&info, 0, sizeof(struct i2c_board_info)); > - memset(&init_data, 0, sizeof(struct IR_i2c_init_data)); > + init_data = kzalloc(sizeof(struct IR_i2c_init_data), GFP_KERNEL);
you need to free it at the proper places. Anyway, we have already a fix for it at:
http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-next.git;a=commit;h=3a7ec2c0d6fdda454d5588c03208ddfcbe16ac18
(I'll probably rework on it a little bit to remove the memset's and to fix a typo)
Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |