Messages in this thread | | | Date | Tue, 8 Sep 2009 08:58:32 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH 3/8] Simplify exec_permission_lite() further |
| |
On Tue, Sep 08, 2009 at 03:40:12PM +0100, Jamie Lokier wrote: > Linus Torvalds wrote: > > This function is only called for path components that are already known > > to be directories (they have a '->lookup' method). So don't bother > > doing that whole S_ISDIR() testing, > > A few years ago you briefly discussed diddling the VFS to accept > objects which are both files and directories. That is, have > ->lookup() and also can be read as regular files. > > I don't know if your thinking has changed, and I don't particularly > care, only thought I'd remind in case it's something you'd like to > support at some point.
If it's being used as a component of a pathname, we're _using_ it as a directory, so it won't matter for this case.
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |