lkml.org 
[lkml]   [2009]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section.
From: Tim Abbott <tabbott@ksplice.com>
Subject: [PATCH 5/6] m32r: Move the spi_stack_top and spu_stack_top into .data section.
Date: Sun, 06 Sep 2009 23:12:58 -0400
> Since these get squashed into the .data output section by the m32r
> linker script, it seems likely that they don't need their own input
> sections.
>
> I'd like an explicit confirmation from Hirokazu Takata that this is
> correct (in particular, that there isn't some hidden reason why there
> two structures need to be at the start of the .data output section).

There is no apparent reason. We've placed them at the start of .data
section, because they are for initial stack region.

I think it would be better that we place them to .init.data section.
Any comment?

> This patch is preparation for cleaning up the m32r architecture to use
> the new macros in vmlinux.lds.h; if these sections are indeed not
> needed, then we can use the RW_DATA_SECTION macro for m32r and save a
> bunch of redundant code.
>
> Signed-off-by: Tim Abbott <tabbott@ksplice.com>
> Cc: Hirokazu Takata <takata@linux-m32r.org>
> ---
> arch/m32r/kernel/head.S | 4 ++--
> arch/m32r/kernel/vmlinux.lds.S | 2 --
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/m32r/kernel/head.S b/arch/m32r/kernel/head.S
> index 0a71944..fc4d769 100644
> --- a/arch/m32r/kernel/head.S
> +++ b/arch/m32r/kernel/head.S
> @@ -268,13 +268,13 @@ ENTRY(empty_zero_page)
> /*------------------------------------------------------------------------
> * Stack area
> */
> - .section .spi
> + .section .data
> ALIGN
> .global spi_stack_top
> .zero 1024
> spi_stack_top:
>
> - .section .spu
> + .section .data
> ALIGN
> .global spu_stack_top
> .zero 1024
> diff --git a/arch/m32r/kernel/vmlinux.lds.S b/arch/m32r/kernel/vmlinux.lds.S
> index eb3e425..1984b9f 100644
> --- a/arch/m32r/kernel/vmlinux.lds.S
> +++ b/arch/m32r/kernel/vmlinux.lds.S
> @@ -49,8 +49,6 @@ SECTIONS
>
> /* writeable */
> .data : { /* Data */
> - *(.spu)
> - *(.spi)
> DATA_DATA
> CONSTRUCTORS
> }
> --
> 1.6.3.3
>

-- Takata


\
 
 \ /
  Last update: 2009-09-07 14:33    [W:0.048 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site