lkml.org 
[lkml]   [2009]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Add poll_get_char and poll_put_char uart_ops to atmel_serial.
From
hi Albin,

Any reason you're not using the register access macro's like the rest
of the driver?

> + while (!(__raw_readl(aup->uart.membase + ATMEL_US_CSR) & ATMEL_US_RXRDY))

while (!(UART_GET_CSR(..) & ATMEL_US_RXRDY))

> + return __raw_readl(aup->uart.membase + ATMEL_US_RHR);

return UART_GET_CHAR(..);

> + __raw_writel(ch, aup->uart.membase + ATMEL_US_THR);

UART_PUT_CHAR(..., ch);


Otherwise the patch looks fine to me.

Regards,
Andrew Victor


\
 
 \ /
  Last update: 2009-09-07 08:25    [W:0.095 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site