lkml.org 
[lkml]   [2009]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [2.6.31-rc8] Problem with detect USB devices
From
Date
On Fri, 2009-09-04 at 20:30 +0200, Maciej Rutecki wrote:
> 2009/9/4 Maciej Rutecki <maciej.rutecki@gmail.com>:
> > 2009/9/4 Oliver Neukum <oliver@neukum.org>:
> >
> >>
> >> Maciej,
> >>
> >> can you run a git bisection?
> >>
>
>
> 0db501bd0610ee0c0aca84d927f90bcccd09e2bd is first bad commit
> commit 0db501bd0610ee0c0aca84d927f90bcccd09e2bd
> Author: Eric W. Biederman <ebiederm@xmission.com>
> Date: Thu Aug 27 03:20:04 2009 -0700
>
> inotify: Ensure we alwasy write the terminating NULL.
>
> Before the rewrite copy_event_to_user always wrote a terqminating '\0'
> byte to user space after the filename. Since the rewrite that
> terminating byte was skipped if your filename is exactly a multiple of
> event_size. Ouch!
>
> So add one byte to name_size before we round up and use clear_user to
> set userspace to zero like /dev/zero does instead of copying the
> strange nul_inotify_event. I can't quite convince myself len_to_zero
> will never exceed 16 and even if it doesn't clear_user should be more
> efficient and a more accurate reflection of what the code is trying to
> do.
>
> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
> Signed-off-by: Eric Paris <eparis@redhat.com>
>
> :040000 040000 ae8bc8bebfd205cde1f7b7689f60a2ada08b1e24
> 7be919a71e3e27510ec38f95664a5e770ce82ad8 M fs
>
> Unfortunately I cannot revert it (to make sure):
> root@gumis:/usr/src/git/linux-2.6# git revert
> 0db501bd0610ee0c0aca84d927f90bcccd09e2bd
> Automatic revert failed. After resolving the conflicts,
> mark the corrected paths with 'git add <paths>' or 'git rm <paths>'
> and commit the result.

Update to Linus's newest git tree. It has a fix for this problem.
Sorry for all the trouble.

-Eric



\
 
 \ /
  Last update: 2009-09-04 20:37    [W:0.075 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site