lkml.org 
[lkml]   [2009]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] VT: Add a boot option to disable cursor on boot
On Fri,  4 Sep 2009 11:48:09 -0400
Matthew Garrett <mjg@redhat.com> wrote:

> The VT code currently enables a visible cursor on boot. This is a fairly
> unnecessary visual distraction for setups which boot to a splash screen
> before going directly into X, so add a boot option (vt.hide_boot_cursor=1)
> that doesn't enable the cursor for initial VT setup. VT resets and any
> later VT creation will leave the cursor turned on, as before.

Seems odd to me - why can't the splash screen app in initrd just issue
the call to turn off the cursor - or is this splash screen coming from
something else ?

Either way the implementation in your patch is butt-ugly adding an extra
special case all over the place.

IMHO
- If the splash screen is kernel based then the splash screen module
needs to be able to ask the vt driver itself
- If not then the user space can use ioctls like everyone else (see
setterm)
- It should be implemented without adding an extra condition to a pile of
ifs (or the condition mess at least become a single cursor_visible_p())

Alan


\
 
 \ /
  Last update: 2009-09-04 18:05    [W:6.360 / U:2.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site