lkml.org 
[lkml]   [2009]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/3] tracing - adding common method for reading/parsing user input
    From
    Date

    On Fri, 2009-09-04 at 15:31 +0200, jolsa@redhat.com wrote:
    > As 3 different places for 4 user input files were using the same way
    > of reading and parsing user's input, I made one common routine to be
    > used.
    >
    > The mentioned files are:
    > set_graph_function
    > set_event
    > set_ftrace_filter
    > set_ftrace_notrace
    >

    Hi Jolsa,

    I'll take a look at these. I know there's duplicate code that I even
    wrote a "generic" handler for others to use, that basically got a NAK
    from Andrew Morton. I probably could have put it into the ftrace code
    directly, but never did so.

    It will be interesting to look at your patches, especially when those
    functions all do things quite differently, with the exception of
    set_ftrace_filter and set_ftrace_notrace.

    Note, all your patches have [PATCH 0/3] in the subject. I think I can
    figure out the order, but you will want to fix that on your next
    version.

    Currently I'm bug fixing other areas that need a bit of attention. I'll
    add this to my queue.

    Thanks,

    -- Steve




    \
     
     \ /
      Last update: 2009-09-04 15:53    [W:0.022 / U:29.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site